ktmud opened a new pull request #16450: URL: https://github.com/apache/superset/pull/16450
### SUMMARY More explicitly handle `Infinity` values in query results and improve type inference related to infinity values. Previously we treat `Infinity` as `N/A` since JSON cannot handle infinity values. This PR explicitly retains infinity values in Pandas dataframes and adds two fields in data response (`infs` and `-infs`) to return to the client side which `null`s in the data records are actually infinities. The client side can then convert them back into JavaScript `Infinity/-Infinity` (not the scope of this PR). More unit tests to come. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
