villebro commented on a change in pull request #16463:
URL: https://github.com/apache/superset/pull/16463#discussion_r696495797
##########
File path: .pylintrc
##########
@@ -86,6 +86,8 @@ disable=
missing-docstring,
too-many-lines,
duplicate-code,
+ unspecified-encoding,
Review comment:
I don't necessarily agree with this rule. While we could add
`encoding="utf-8"` to all text file opens, this would likely break
compatibility with Windows which defaults to `cp-1252` (not officially
supported, but I know some parties in the community are running Superset on
Windows). Also, adding `encoding=locale.getpreferredencoding()` feels
pointless. So I recommend we disable this rule for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
