john-bodley commented on a change in pull request #16463:
URL: https://github.com/apache/superset/pull/16463#discussion_r696834834
##########
File path: superset/annotation_layers/annotations/api.py
##########
@@ -381,7 +381,7 @@ def put( # pylint: disable=arguments-differ
try:
new_model = UpdateAnnotationCommand(g.user, annotation_id,
item).run()
return self.response(200, id=new_model.id, result=item)
- except (AnnotationNotFoundError, AnnotationLayerNotFoundError) as ex:
+ except (AnnotationNotFoundError, AnnotationLayerNotFoundError):
Review comment:
I'm always happy to see Pylint is continuing to evolve it's logic.
##########
File path: superset/tasks/async_queries.py
##########
@@ -68,7 +68,7 @@ def load_chart_data_into_cache(
raise exc
except Exception as exc:
# TODO: QueryContext should support SIP-40 style errors
- error = exc.message if hasattr(exc, "message") else str(exc) # type:
ignore # pylint: disable=no-member
+ error = exc.message if hasattr(exc, "message") else str(exc) # type:
ignore
Review comment:
@villebro as a side note I might do a pass to remain `exc` to `ex` for
consistency throughout the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
