ktmud commented on a change in pull request #16511:
URL: https://github.com/apache/superset/pull/16511#discussion_r698705647
##########
File path: superset-frontend/src/chart/Chart.jsx
##########
@@ -178,7 +178,12 @@ class Chart extends React.PureComponent {
const message = chartAlert || queryResponse?.message;
// if datasource is still loading, don't render JS errors
- if (chartAlert && datasource === PLACEHOLDER_DATASOURCE) {
+ if (
+ chartAlert !== undefined &&
+ chartAlert !==
+ 'The dataset associated with this chart no longer exists' &&
Review comment:
Can we make this a const?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
