pkdotson opened a new pull request #16511:
URL: https://github.com/apache/superset/pull/16511


   ### SUMMARY
   This pr stops the endless loading in the dashboards when a dataset does no 
longer exists and returns proper error info to the user. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   before
   
   
https://user-images.githubusercontent.com/17326228/131378812-5f92c50a-434c-48b3-857b-47b52c567976.mov
   
   after
   
   
https://user-images.githubusercontent.com/17326228/131379074-cf9d01df-79c1-490e-81a2-9fd49dde63dc.mov
   
   
   
   ### TESTING INSTRUCTIONS
   Delete a dataset that has associated chart in a a dashboard.
   Go to the dashboard and ensure that the charts do no endlessly load.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x ] Has associated issue: Fixes 
https://github.com/apache/superset/issues/16431
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to