m-ajay opened a new pull request #16549:
URL: https://github.com/apache/superset/pull/16549


   ### SUMMARY
   In a future PR, we  will add a "Section" component to the native filters. We 
will need a new key to distinguish between them.
   
   ### TESTING INSTRUCTIONS
   **Testing existing filters**
   1. Run migration using `superset db upgrade`
   2. Verify in the dashboards DB table that all the filters have a type (Check 
`json_metadata` column in dashboards table)
   **Testing new filters** 
   1. Add a new filter
   2. Make sure that the type key appears in the new filter (Check 
`json_metadata` column in dashboards table)
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to