m-ajay commented on pull request #16549: URL: https://github.com/apache/superset/pull/16549#issuecomment-911958530
> Hi @m-ajay this PR is good. After this PR is merged and migration is executed, all exist native filter components should have a `type` property, but how about new filter component in the new dashboard, which will be created in the near future? > Besides migration, should we also add default `type` in the code at the same time? @grace Thanks for the review. I'm adding `type` as `NATIVE_FILTER` when creating a new filter. In the future, when we add a section, we will add `type` as `SECTION` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
