duynguyenhoang opened a new pull request #16612:
URL: https://github.com/apache/superset/pull/16612


   ### SUMMARY
   Introduce a page for Forbidden error.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before
   
![image](https://user-images.githubusercontent.com/7106179/132254180-c095ce80-f541-4ea0-b8f4-1b503c6cfa6b.png)
   
   After
   
![image](https://user-images.githubusercontent.com/7106179/132254167-cd7158b4-0537-4ef1-9477-87e835d2cb6b.png)
   
   ### TESTING INSTRUCTIONS
   - Enable DASHBOARD_RBAC
   - Login with a user who doesn't have access to a dashboard.
   - Verify that the new 403 page appear.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixes #16611
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   Note: I copied `error404.png` to `error403.png`, I think design team can 
provide the correct design for it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to