ofekisr commented on a change in pull request #14015: URL: https://github.com/apache/superset/pull/14015#discussion_r705444055
########## File path: superset/models/filter_set.py ########## @@ -0,0 +1,99 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import logging +from typing import Any, Dict + +from flask_appbuilder import Model +from sqlalchemy import Column, ForeignKey, Integer, JSON, MetaData, String, Text +from sqlalchemy.orm import relationship +from sqlalchemy_utils import generic_relationship + +from superset import app, db +from superset.models.helpers import AuditMixinNullable + +metadata = Model.metadata # pylint: disable=no-member +config = app.config +logger = logging.getLogger(__name__) + + +class FilterSet(Model, AuditMixinNullable): + __tablename__ = "filter_sets" + id = Column(Integer, primary_key=True) + name = Column(String(500), nullable=False, unique=True) + description = Column(Text, nullable=True) + json_metadata = Column(JSON, nullable=False) Review comment: I didn't investigate what is better, but if you think Text is better then JSON, it should be in separate PR that change all JSON to TXT and not only here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
