ofekisr commented on a change in pull request #14015: URL: https://github.com/apache/superset/pull/14015#discussion_r707500847
########## File path: superset/migrations/versions/3ebe0993c770_filterset_table.py ########## @@ -0,0 +1,56 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""add filter set model + +Revision ID: 3ebe0993c770 +Revises: 07071313dd52 +Create Date: 2021-03-29 11:15:48.831225 + +""" + +# revision identifiers, used by Alembic. +revision = "3ebe0993c770" +down_revision = "07071313dd52" + +import sqlalchemy as sa +from alembic import op + + +def upgrade(): + op.create_table( + "filter_sets", + sa.Column("created_on", sa.DateTime(), nullable=True), + sa.Column("changed_on", sa.DateTime(), nullable=True), + sa.Column("id", sa.Integer(), nullable=False), + sa.Column("name", sa.VARCHAR(500), nullable=False), + sa.Column("description", sa.Text(), nullable=True), + sa.Column("json_metadata", sa.JSON(), nullable=False), Review comment: Dashboard model uses JSON as well and it is very convenient to use... If I expect to Json object why not use JSON? why do you use int and not everything as string? Please explain to us why JSON is bad practice? how are you sure Text is ok? If you trust sqlalchemy you should use their interface. Should Superset support as administration Database others then MySQL, Postgress, SQLite and Microsoft SQL Server 2016 but others? if yes how does Superset support it until now since Dashboard model uses Json as well ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
