dpgaspar commented on a change in pull request #16683:
URL: https://github.com/apache/superset/pull/16683#discussion_r707197431
##########
File path: superset/config.py
##########
@@ -115,10 +115,13 @@ def _try_json_readsha(filepath: str, length: int) ->
Optional[str]:
# default viz used in chart explorer
DEFAULT_VIZ_TYPE = "table"
+# maximum row limit that can be set on a query. Will override the row limit
defined
+# in all queries (both SQL Lab and chart data queries)
+MAX_GLOBAL_ROW_LIMIT: Optional[int] = None
+# default row limit to apply to queries unless set in the query object
ROW_LIMIT = 50000
-VIZ_ROW_LIMIT = 10000
-# max rows retreieved when requesting samples from datasource in explore view
-SAMPLES_ROW_LIMIT = 1000
+# default row limit when requesting samples from datasource in explore view
+SAMPLES_ROW_LIMIT = 100
Review comment:
assuming here that SAMPLES_ROW_LIMIT had no effect except on the
frontend
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
