villebro commented on a change in pull request #16683:
URL: https://github.com/apache/superset/pull/16683#discussion_r709377719
##########
File path: superset/utils/core.py
##########
@@ -1762,3 +1762,29 @@ def parse_boolean_string(bool_str: Optional[str]) ->
bool:
return bool(strtobool(bool_str.lower()))
except ValueError:
return False
+
+
+def apply_max_row_limit(max_limit: Optional[int], limit: int) -> int:
Review comment:
You know you're absolutely right, this current sig is really an artifact
from earlier iterations of this PR. Will update accordingly 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
