villebro opened a new pull request #16699: URL: https://github.com/apache/superset/pull/16699
### SUMMARY Every time control state is updated on the Explore view, the data panel requests new data, even when the changes are known not to affect the chart data (`renderTrigger` property set to true). This PR changes `ExploreChartPanel` to only refresh the `queryFormData` that's used by DataTablesPane` if the `triggerRender` is not true. This only happens when the chart needs to be rerendered without rerequesting data. ### AFTER https://user-images.githubusercontent.com/33317356/133247836-fb2b540a-824e-4521-93a6-c5c70852ef4c.mp4 ### BEFORE https://user-images.githubusercontent.com/33317356/133246743-4139d0f7-40ac-47d1-84b0-bf3aa1139713.mp4 ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
