villebro commented on a change in pull request #16699:
URL: https://github.com/apache/superset/pull/16699#discussion_r708167914
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -257,6 +258,16 @@ const ExploreChartPanel = props => {
[chartPanelRef, renderChart],
);
+ const [queryFormData, setQueryFormData] = useState(
+ props.chart.latestQueryFormData,
+ );
+
+ useEffect(() => {
+ if (!props.triggerRender) {
+ setQueryFormData(props.chart.latestQueryFormData);
+ }
+ }, [props.chart.latestQueryFormData]);
Review comment:
No - that would cause it to trigger when we change controls whose
`renderTrigger` prop is set to `true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
