betodealmeida commented on a change in pull request #6540: Make boto3/botocore
installation optional
URL:
https://github.com/apache/incubator-superset/pull/6540#discussion_r243678878
##########
File path: superset/db_engine_specs.py
##########
@@ -1065,6 +1064,9 @@ def convert_to_hive_type(col_type):
convert_to_hive_type(column_info['type'])))
schema_definition = ', '.join(column_name_and_type)
+ # Optional dependency
+ import boto3 # pylint: disable=import-error
Review comment:
Ah, true! Though you could set `boto3 = None` in the block capturing the
exception. I'm fine with either, it was just a nit. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
