kgabryje commented on a change in pull request #16701:
URL: https://github.com/apache/superset/pull/16701#discussion_r711026689
##########
File path: superset-frontend/webpack.config.js
##########
@@ -141,17 +152,6 @@ if (!process.env.CI) {
plugins.push(new webpack.ProgressPlugin());
}
-// clean up built assets if not from dev-server
-if (!isDevServer) {
- plugins.push(
- new CleanWebpackPlugin({
- dry: false,
- // required because the build directory is outside the frontend
directory:
- dangerouslyAllowCleanPatternsOutsideProject: true,
- }),
- );
-}
-
Review comment:
Webpack 5 has built-in cleaning capabilities. This line replaces the
plugin:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
