kgabryje commented on a change in pull request #16701:
URL: https://github.com/apache/superset/pull/16701#discussion_r711030825
##########
File path:
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx
##########
@@ -204,10 +204,25 @@ export default class AnnotationLayer extends
React.PureComponent {
return sources;
}
- isValidFormula(value, annotationType) {
+ isValidFormula(expression, annotationType) {
Review comment:
Done
##########
File path:
superset-frontend/cypress-base/cypress/integration/dashboard/markdown.test.ts
##########
@@ -25,10 +25,6 @@ describe('Dashboard edit markdown', () => {
});
it('should load AceEditor on demand', () => {
- let numScripts = 0;
- cy.get('script').then(nodes => {
- numScripts = nodes.length;
- });
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
