betodealmeida commented on a change in pull request #16859:
URL: https://github.com/apache/superset/pull/16859#discussion_r718019572
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -487,17 +512,15 @@ export default class ResultSet extends
React.PureComponent<
onChangeAutoComplete={this.handleOnChangeAutoComplete}
/>
<ResultSetButtons>
- {this.props.visualize &&
- this.props.database &&
- this.props.database.allows_virtual_table_explore && (
Review comment:
Is this no longer needed? Was it replaced by `this.props.visualize`?
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -133,6 +138,27 @@ const ResultSetErrorMessage = styled.div`
padding-top: ${({ theme }) => 4 * theme.gridUnit}px;
`;
+const updateDataset = async (
+ datasetId: number,
+ sql: string,
+ columns: Array<Record<string, any>>,
+ overrideColumns: boolean,
+) => {
+ const endpoint =
`api/v1/dataset/${datasetId}?override_columns=${overrideColumns}`;
Review comment:
We no longer need to pass `override_columns`, right? If so, let's remove
it from the API and from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
