villebro opened a new pull request #16933: URL: https://github.com/apache/superset/pull/16933
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> When dropping a wrapped component (in this case a markdown component, but could be any other component, like a chart), the component is wrapped in a row component. However, the wrapper adds itself as it's own parent:  Sometimes the wrapped component adds the wrapper component as its parent, in which case the cross filter indicator goes into an infinite loop (the cross filter FF needs to be enabled - if it's not enabled, the bug isn't triggered). However, sometimes the wrapped component doesn't add the wrapper as its parent, in which case the dashboard doesn't crash. Interestingly enough, after saving the dashboard, the layout metadata is fixed: - the wrapped component correctly references the wrapper as its closest parent - the wrapper no longer references itself See the screenshot below for the post-save state:  This bug exposed several problems in the associated code, causing unnecessary performance problems. However, these should be fixed in follow-up PRs. ### TESTING INSTRUCTIONS Local testing ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
