villebro commented on a change in pull request #16933:
URL: https://github.com/apache/superset/pull/16933#discussion_r720274222
##########
File path: superset-frontend/src/dashboard/util/newEntitiesFromDrop.js
##########
@@ -51,8 +51,8 @@ export default function newEntitiesFromDrop({ dropResult,
layout }) {
rowWrapper.children = [newDropChild.id];
rowWrapper.parents = (dropEntity.parents || []).concat(dropEntity.id);
newEntities[rowWrapper.id] = rowWrapper;
- newDropChild = rowWrapper;
newDropChild.parents = rowWrapper.parents.concat(rowWrapper.id);
+ newDropChild = rowWrapper;
Review comment:
The intent here was clearly to add the wrapper as the parent to the
wrapped component - due to the incorrect order here the wrapper's id was
incorrectly added to its own parents, not the wrapped component's ids.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
