geido opened a new pull request #17013:
URL: https://github.com/apache/superset/pull/17013


   ### SUMMARY
   This PR fixes an edge case with the Select component. With dynamic controls 
there might be the case where a default value is being passed as `null` when it 
was intended to be `undefined`. This change makes sure that a `null` value that 
is not available in the options is considered as`undefined` instead.
   
   ### BEFORE
   ![Screen Shot 2021-10-07 at 17 35 
15](https://user-images.githubusercontent.com/60598000/136406429-fc33a0d2-afd0-48bf-838d-0168d1c83ce9.png)
   
   ### AFTER
   ![Screen Shot 2021-10-07 at 17 33 
45](https://user-images.githubusercontent.com/60598000/136406179-3ee489de-0cdd-4c01-9ece-38ccdd60df43.png)
   
   ### TESTING INSTRUCTIONS
   1. Create a Histogram chart
   2. Observe the Columns control
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to