michael-s-molina commented on a change in pull request #16992:
URL: https://github.com/apache/superset/pull/16992#discussion_r727541889



##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -51,6 +51,7 @@ export interface ModalProps {
   centered?: boolean;
   footer?: React.ReactNode;
   wrapProps?: object;
+  maskStyle?: object;

Review comment:
       @graceguo-supercat Is there a reason to keep the menu bar out of the 
modal mask? If the user can perform other actions instead of interacting with 
the modal, we should probably use a 
[notification](https://ant.design/components/notification/).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to