graceguo-supercat commented on a change in pull request #16992:
URL: https://github.com/apache/superset/pull/16992#discussion_r726510318
##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -51,6 +51,7 @@ export interface ModalProps {
centered?: boolean;
footer?: React.ReactNode;
wrapProps?: object;
+ maskStyle?: object;
Review comment:
add this props from AntD. I want to show the top Superset menu bar out
of modal mask:
<img width="1411" alt="Screen Shot 2021-10-11 at 12 06 23 PM"
src="https://user-images.githubusercontent.com/27990562/136843526-7ebbd472-9c1f-4c4e-b490-99596dda0b30.png";>
##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -51,6 +51,7 @@ export interface ModalProps {
centered?: boolean;
footer?: React.ReactNode;
wrapProps?: object;
+ maskStyle?: object;
Review comment:
add this props from AntD. I want to keep the top Superset menu bar out
of modal mask:
<img width="1411" alt="Screen Shot 2021-10-11 at 12 06 23 PM"
src="https://user-images.githubusercontent.com/27990562/136843526-7ebbd472-9c1f-4c4e-b490-99596dda0b30.png";>
##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -51,6 +51,7 @@ export interface ModalProps {
centered?: boolean;
footer?: React.ReactNode;
wrapProps?: object;
+ maskStyle?: object;
Review comment:
what if user opens on a dashboard_1, feels too much work to do, and
decided to do some other work, like another dashboard or chart, or sql lab? If
i cover whole page with modal (default behavior), user have no way out of this
situation right?
##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -51,6 +51,7 @@ export interface ModalProps {
centered?: boolean;
footer?: React.ReactNode;
wrapProps?: object;
+ maskStyle?: object;
Review comment:
what if user opens on a dashboard_1, feels too much work to do, and
decided to do some other work, like another dashboard or chart, or sql lab? If
i cover whole page with modal (default behavior), user have no way to get out
of this situation right?
##########
File path: superset-frontend/src/components/Modal/Modal.tsx
##########
@@ -51,6 +51,7 @@ export interface ModalProps {
centered?: boolean;
footer?: React.ReactNode;
wrapProps?: object;
+ maskStyle?: object;
Review comment:
what if user opens on a dashboard_1, feels too much work to do, and
decided to do some other work, like another dashboard or chart, or sql lab? If
i cover whole page with modal (default behavior), user have no way to get out
of this situation right?
For users with `ENABLE_FILTER_BOX_MIGRATION` flag, i want to enforce a
choice before they move forward (review now or later). But for users without
ENABLE_FILTER_BOX_MIGRATION flag, I will show non-blocking toast message (see
2nd screen in the **After** section)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/27990562/136843526-7ebbd472-9c1f-4c4e-b490-99596dda0b30.png"](https://user-images.githubusercontent.com/27990562/136843526-7ebbd472-9c1f-4c4e-b490-99596dda0b30.png"){kind=link}