mayurnewase opened a new pull request #17106: URL: https://github.com/apache/superset/pull/17106
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Currently dashboard and chart checks for anonymous user by just check `user` variable existance in store, but anonymous user can exists with that object and permissions allowed on public role without authenticating without user id. So logic inside reports fails as it tries to encode payload with undefined user id,so check for anonymous user by explicitly checking for valid user id is present. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before, when visiting a public dashboard without authentication  After, it loads without report button  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Setup public dashboard and get public url Setup public user with permissions to that dashboard Log out and visit the dashboard ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/16718 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
