kgabryje opened a new pull request #17201: URL: https://github.com/apache/superset/pull/17201
### SUMMARY Before, when a custom metric that was currently selected got removed from dataset, all selected metrics where cleared and user had to rebuild their chart. This PR fixes that behaviour by removing from metrics picker only those custom metrics that were removed from dataset. Also, if user removes a column from dataset, the adhoc metrics that use that column will also be removed. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: see linked issue After: https://user-images.githubusercontent.com/15073128/138493397-8a6a218a-60b3-4ef0-b1e7-996264b349eb.mov ### TESTING INSTRUCTIONS Follow the reproduction steps from linked issue, make sure that only the metric that got removed from dataset is removed from metrics picker. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: fixes #16719 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC @graceguo-supercat @rusackas @junlincc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
