graceguo-supercat edited a comment on pull request #17201: URL: https://github.com/apache/superset/pull/17201#issuecomment-951282715
Hi @kgabryje thanks for the work! with the latest fix, non-dnd controls work good. But here i have another question for this solution. In the current workflow, when front-end found any invalid `metrics` parameter, front-end will not display it, but the bad data is still in the Slice entity: <img width="602" alt="Screen Shot 2021-10-25 at 1 14 51 PM" src="https://user-images.githubusercontent.com/27990562/138764109-49849856-e2c7-4b15-b844-0cfb1dae972f.png";> in the above example, `max` is invalid metrics. Front-end knows how to handle it, but should this bad data be buried quietly and stay in `Slices` table forever? Ideally, Superset should let user know which piece of data is not valid anymore, and ask user to take action to clean up this bad data. right? cc @villebro @john-bodley @junlincc for suggestions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/27990562/138764109-49849856-e2c7-4b15-b844-0cfb1dae972f.png"](https://user-images.githubusercontent.com/27990562/138764109-49849856-e2c7-4b15-b844-0cfb1dae972f.png"){kind=link}