[GitHub] [superset] john-bodley opened a new pull request #17202: feat(metrics): Provide override for disabling ad-hoc metrics

[GitBox]

john-bodley opened a new pull request #17202:
URL: https://github.com/apache/superset/pull/17202


   ### SUMMARY
   
   There could be some instances where ad-hoc metrics for specific datasets 
should be disabled, i.e., the dataset owner specifically does not users to 
create ad-hoc non-sanctioned metrics. This PR adds—at the dataset level—a 
custom override for disabling ad-hoc metrics, i.e., removing the `SIMPLE` and 
`CUSTOM SQL` tabs.
   
   Note for the native Druid connector I also removed the `CUSTOM SQL` tab 
(which housed a message as to why this was invalid) to ensure consistency with 
the ad-hoc filters.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Disallowed
   
   <img width="315" alt="Screen Shot 2021-10-22 at 11 29 21 AM" 
src="https://user-images.githubusercontent.com/4567245/138507423-ab3a5916-4675-4b75-b088-7b3b115e4c10.png";>
   
   #### Allowed (default)
   
   <img width="316" alt="Screen Shot 2021-10-22 at 11 30 10 AM" 
src="https://user-images.githubusercontent.com/4567245/138507430-4d751d93-fe83-4a7e-8bc7-fd28715cd245.png";>
   
   ### TESTING INSTRUCTIONS
   
   Added unit tests.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org