john-bodley commented on a change in pull request #17202:
URL: https://github.com/apache/superset/pull/17202#discussion_r737017754
##########
File path:
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.jsx
##########
@@ -173,90 +168,66 @@ export default class AdhocFilterEditPopover extends
React.Component {
onResize,
datasource,
partitionColumn,
- sections = ['SIMPLE', 'CUSTOM_SQL'],
theme,
operators,
...popoverProps
} = this.props;
const { adhocFilter } = this.state;
-
- const resultSections =
- datasource?.type === 'druid'
- ? sections.filter(s => s !== 'CUSTOM_SQL')
- : sections;
-
const stateIsValid = adhocFilter.isValid();
const hasUnsavedChanges = !adhocFilter.equals(propsAdhocFilter);
- const sectionRenders = {};
-
- sectionRenders.CUSTOM_SQL = (
Review comment:
Moved to be inline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
