graceguo-supercat commented on a change in pull request #16992:
URL: https://github.com/apache/superset/pull/16992#discussion_r735781067
##########
File path: superset-frontend/src/chart/Chart.jsx
##########
@@ -113,13 +115,25 @@ class Chart extends React.PureComponent {
}
componentDidMount() {
- if (this.props.triggerQuery) {
+ // during migration, hold chart queries before user choose review or cancel
+ if (
+ this.props.triggerQuery &&
+ this.props.filterboxMigrationState !== 'UNDECIDED'
+ ) {
this.runQuery();
}
}
componentDidUpdate() {
- if (this.props.triggerQuery) {
+ // during migration, hold chart queries before user choose review or cancel
Review comment:
I added this logic, when the migration modal is showing for user to
decide to move to review mode or not, do not send query to the backend query
engine. Just want to make this transition mode impact less on dashboard
performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
