graceguo-supercat commented on a change in pull request #16992:
URL: https://github.com/apache/superset/pull/16992#discussion_r740657930
##########
File path: superset-frontend/src/dashboard/components/DashboardBuilder/state.ts
##########
@@ -75,11 +77,12 @@ export const useNativeFilters = () => {
if (
filterValues.length === 0 &&
dashboardFiltersOpen &&
- nativeFiltersEnabled
+ nativeFiltersEnabled &&
+ ['CONVERTED', 'REVIEWING', 'NOOP'].includes(filterboxMigrationState)
Review comment:
this line fixed the dashboard left margin issue.
this is very tricky bug. I can reproduce this issue only when:
0. enable feature flag,
1. open dashboard list page,
2. click a dashboard.
if i open dashboard from its own dashboard link, can't see this left-margin
problem :joy:
##########
File path: superset-frontend/src/dashboard/components/DashboardBuilder/state.ts
##########
@@ -75,11 +77,12 @@ export const useNativeFilters = () => {
if (
filterValues.length === 0 &&
dashboardFiltersOpen &&
- nativeFiltersEnabled
+ nativeFiltersEnabled &&
+ ['CONVERTED', 'REVIEWING', 'NOOP'].includes(filterboxMigrationState)
Review comment:
this line fixed the dashboard left margin issue. It is a very tricky
bug. I can reproduce only by these steps:
0. enable feature flag,
1. open dashboard list page,
2. click a dashboard.
if i open dashboard from its own dashboard link, can't see this left-margin
problem :joy:. hope now i fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
