john-bodley opened a new pull request #17236: URL: https://github.com/apache/superset/pull/17236
### SUMMARY This PR is one of a slew to the [apache/superset](https://github.com/apache/superset) and [apache-superset/superset-ui](https://github.com/apache-superset/superset-ui) repos to revert pseudo recent changes to the series restrictions for high cardinality groupings. For more context please refer to [this](https://apache-superset.slack.com/archives/G013HAE6Y0K/p1635192289021500) Slack thread in the #committers channel. Specifically this PR reverts https://github.com/apache/superset/pull/15343, i.e., does not fallback to the first selected metric and requires the user to specify a sort-by metric for improved UX. Note previously there was inconsistency in the results when no ordering was specified and thus this PR ensures that a series limit must be defined in conjunction with a series sort-by metric. Ideally the UI controls would handle this logic, however for now it merely validates the query object. Finally this PR re-orders some of the UI elements, i.e., the series limit metric is defined prior to the limit as this is more inline with how people think about querying, i.e., one normally specifies the `ORDER BY` clause prior to the `LIMIT` clause. Related PRs: - https://github.com/apache-superset/superset-ui/pull/1430 - https://github.com/apache-superset/superset-ui/pull/1436 ### TESTING INSTRUCTIONS Added unit tests and tested manually. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
