xingyc15 opened a new pull request #17237: URL: https://github.com/apache/superset/pull/17237
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Fix the timestamp expression in sqla model.py, adding jinja template processor to it. ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ``` diff --git a/docker/pythonpath_dev/superset_config.py b/docker/pythonpath_dev/superset_config.py index 6c58bec79..83ebedca1 100644 --- a/docker/pythonpath_dev/superset_config.py +++ b/docker/pythonpath_dev/superset_config.py @@ -99,6 +99,15 @@ WEBDRIVER_BASEURL_USER_FRIENDLY = WEBDRIVER_BASEURL SQLLAB_CTAS_NO_LIMIT = True +# Local env test +FEATURE_FLAGS = { + "ENABLE_TEMPLATE_PROCESSING": True +} + +JINJA_CONTEXT_ADDONS = { + 'jinja_tmpl': 'date' +} + ``` Apply the above changes, run `docker build -t apache/superset:latest-dev .` and then use `docker-compose` to start the superset app. Go to localhost:8088 in browser and login to superset. Go to dataset, find **cleaned_sales_data** and go to calculated columns, add a new item like this: <img width="880" alt="Screen Shot 2021-10-26 at 12 23 30 PM" src="https://user-images.githubusercontent.com/33602700/138947191-34c89399-012d-4543-89a4-f550ddfba964.png";> Then go to the chart **Proportion of Revenue by Product Line**, choose the jinja_date as time column and run. The chart should works fine without error. View the query and the order_{{ jinja_tmpl }} is already replaced by "order_date". ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #16984 - [x] Required feature flags: `"ENABLE_TEMPLATE_PROCESSING": True` - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/33602700/138947191-34c89399-012d-4543-89a4-f550ddfba964.png"](https://user-images.githubusercontent.com/33602700/138947191-34c89399-012d-4543-89a4-f550ddfba964.png"){kind=link}