eschutho commented on a change in pull request #17176:
URL: https://github.com/apache/superset/pull/17176#discussion_r739434493
##########
File path: superset-frontend/src/components/AsyncAceEditor/index.tsx
##########
@@ -153,7 +152,6 @@ export default function AsyncAceEditor(
theme={theme}
tabSize={tabSize}
defaultValue={defaultValue}
- value={value || ''}
Review comment:
There was a bug that I fixed on sql lab where if you passed in `value`
as `null` (not undefined), sql lab would crash. Can you test to see if this was
fixed with the new version of aceeditor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
