AAfghahi commented on a change in pull request #17176:
URL: https://github.com/apache/superset/pull/17176#discussion_r738528742
##########
File path: superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
##########
@@ -1136,7 +1136,8 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
maxLines={15}
onChange={onSQLChange}
readOnly={false}
- value={currentAlert ? currentAlert.sql : ''}
+ defaultValue={currentAlert?.sql}
Review comment:
my thought process was that since TextArea, unlike TextAreaControl, is a
controlled component that we would need a changing value, which
currentAlert.sql is. Looking through the code, there is currently no place
where we do use TextArea, we always pass in a language. But I wanted to not
accidentally mess something up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
