cccs-joel opened a new pull request #17360:
URL: https://github.com/apache/superset/pull/17360


   ### SUMMARY
   Some columns such as the ones representing a complex structure (array, 
struct, enum or a combination of these) may require more than 32 chars to store 
the datatype. Changing datatype to TEXT and no limit was suggested by @villebro 
in the 1st associated issue listed below.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before: 
   
![image](https://user-images.githubusercontent.com/62111795/140554250-c6a289ea-4952-45bc-bada-df85f8531fc5.png)
   After:
   
![image](https://user-images.githubusercontent.com/62111795/140554304-507a9ae2-7c09-4733-97ee-4cb7e29e3786.png)
   
   ### TESTING INSTRUCTIONS
   After the migration, easiest way to test is to edit an existing dataset and 
change the type value of a column (using the legacy datasource editor) to 
something larger than 32 characters, Superset should accept the change and 
confirm the row was changed in the database. 
   
   ### ADDITIONAL INFORMATION
   - [X] Has associated issue:
    * https://github.com/apache/superset/issues/13572
    * https://github.com/apache/superset/issues/13690
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [X] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [X] Migration is atomic, supports rollback & is backwards-compatible
     - [X] Confirm DB migration upgrade and downgrade tested
     - [X] Runtime estimates and downtime expectations provided: downtime is 
minimal, takes a second to execute the script.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to