john-bodley opened a new pull request #17383: URL: https://github.com/apache/superset/pull/17383
### SUMMARY This is a partial revert of https://github.com/apache/superset/pull/17236 as it seems other chart types EChart, [Bar Chart](https://github.com/apache/superset/pull/15318), etc. already perform an implicit ordering if undefined, i.e., the ship has sailed on this one. I also added updated comments to reflect this behavior. Personally I'm a tad upset/frustrated that this behavior differs by chart type (search for `sort_by` in [viz.py](https://github.com/apache/superset/blob/master/superset/viz.py)) as this simply adds confusion to the user and leads to a very inconsistent UX. We we introduce new behaviors we should: 1. Strive to make them consistent throughout. 2. Indicate said changes in `UPDATING.md` so institutions can inform/educate users of said changes. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS CI. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
