etr2460 commented on a change in pull request #17383:
URL: https://github.com/apache/superset/pull/17383#discussion_r747116832



##########
File path: superset/utils/core.py
##########
@@ -1326,6 +1326,11 @@ def get_metric_names(metrics: Sequence[Metric]) -> 
List[str]:
     return [metric for metric in map(get_metric_name, metrics) if metric]
 
 
+def get_first_metric_name(metrics: Sequence[Metric]) -> Optional[str]:

Review comment:
       this should probably be `get_first_metric_label`, but i'll stamp because 
it's only a revert




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to