geido opened a new pull request #17392: URL: https://github.com/apache/superset/pull/17392
### SUMMARY This PR adds the `onlyApply` prop to the properties modal of the Dashboard, so that changes will only be applied but not saved. This is to avoid confusion with discarded changes that were actually saved. ### BEFORE Fixes #17243 ### AFTER https://user-images.githubusercontent.com/60598000/141163753-93d37667-5205-45d4-a534-2a78b44c59bc.mp4 ### TESTING INSTRUCTIONS 1. Open a Dashboard 2. Edit its properties and apply 3. Discard the changes 4. Make sure the changes were actually discarded ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #17243 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
