michael-s-molina commented on a change in pull request #17392:
URL: https://github.com/apache/superset/pull/17392#discussion_r747656566
##########
File path:
superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx
##########
@@ -198,3 +198,12 @@ test('should show the properties modal', async () => {
userEvent.click(screen.getByText('Edit dashboard properties'));
expect(editModeOnProps.showPropertiesModal).toHaveBeenCalledTimes(1);
});
+
+test('should only apply changes in the properties modal', async () => {
Review comment:
I was confused by the name of the test and what it's actually doing.
It's only checking that there's a button called Apply but it's not checking if
the changes are only being applied and not saved. Maybe rename to 'should
display the Apply button when opening the modal'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
