ofekisr opened a new pull request #17400: URL: https://github.com/apache/superset/pull/17400
### **Background** When we have worked on #16991 we wanted to test the new functionalities in concrete and accurate unittest. The whole the chartData flows and its components are too couple to superset so it is impossible to create unittests. The flows are not testable and so many components do not meet the very important principle SRP and the code became so dirty So I've started to refactor it (#17344 ) but many changes were added and it was hard to review so I decided to split those changes into small PRs so will be easier to follow this is the second PR after #17399 ### PR description Create new view - ChartDataRestApi in new module but inherit ChartRestApi then moves all chart data endpoints to that new view so the view will be focused only on chartData ### Test plans There are no logic changes so new tests are not required but in the next PRs, I'll split the API tests into new separate modules and classes ## previous PRs 1. #17399 move ChartDataResult enums to common -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
