ofekisr commented on a change in pull request #17400:
URL: https://github.com/apache/superset/pull/17400#discussion_r747374866



##########
File path: superset/charts/api.py
##########
@@ -105,9 +99,6 @@ def ensure_thumbnails_enabled(self) -> Optional[Response]:
         RouteMethod.IMPORT,
         RouteMethod.RELATED,
         "bulk_delete",  # not using RouteMethod since locally defined
-        "data",

Review comment:
       I move them to ChartDataRestApi to avoid duplications and mental 
confusion because that class should not aware that other are inherited it 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to