ofekisr opened a new pull request #17405: URL: https://github.com/apache/superset/pull/17405
## **Background** When we have worked on #16991 we wanted to test the new functionalities in concrete and accurate unittest. The whole the chartData flows and its components are too couple to superset so it is impossible to create unittests. The flows are not testable and so many components do not meet the very important principle SRP and the code became so dirty So I've started to refactor it (#17344 ) but many changes were added and it was hard to review so I decided to split those changes into small PRs so will be easier to follow this is the third PR in a sequence of PRs to meet these ## PR description The CharaDataCommand responsible is to retrieve data given query context parameters. what it needs is query_context injected to him so it can fulfill as purpose so loading the query_contxt form cache should be the responsibility of another module. the module is responsible for creating the command and injecting what the command needs, should charge for calling the cache loader. ### Test plans There are no logic changes, the way the cache is loading is the same as was in the command so new tests are not required ## Previous PRs 1. #17399 2. #17400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
