amitmiran137 commented on a change in pull request #17405:
URL: https://github.com/apache/superset/pull/17405#discussion_r747693076
##########
File path: superset/charts/data/api.py
##########
@@ -362,4 +363,8 @@ def get_data_response(
except ChartDataQueryFailedError as exc:
return self.response_400(message=exc.message)
- return self.send_chart_response(result, form_data)
+ return self._send_chart_response(result, form_data)
+
+ # pylint: disable=invalid-name, no-self-use
+ def _load_query_context_form_from_cache(self, cache_key: str) -> Dict[str,
Any]:
Review comment:
method extraction is overkill here just work directly with the cache
loader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
