michael-s-molina commented on a change in pull request #17337: URL: https://github.com/apache/superset/pull/17337#discussion_r747539542
########## File path: superset/key_value/commands/create.py ########## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import logging +from hashlib import sha3_256 +from typing import Any, Dict, List +from uuid import uuid4 + +from flask import current_app +from flask_appbuilder.models.sqla import Model +from flask_appbuilder.security.sqla.models import User +from marshmallow import ValidationError + +from superset.commands.base import BaseCommand +from superset.dao.exceptions import DAOException +from superset.key_value.commands.exceptions import KeyValueCreateFailedError +from superset.key_value.dao import KeyValueDAO +from superset.models.key_value import KeyValue + +logger = logging.getLogger(__name__) + + +class CreateKeyValueCommand(BaseCommand): + def __init__(self, user: User, data: Dict[str, Any]): + self._actor = user + self._properties = data.copy() + + def run(self) -> Model: + try: + secretKey = current_app.config["SECRET_KEY"] + key = sha3_256(secretKey.encode() + str(uuid4()).encode()).hexdigest() Review comment: I ended up using https://docs.python.org/3/library/secrets.html#secrets.token_urlsafe for the key generation 😉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
