michael-s-molina commented on pull request #17337: URL: https://github.com/apache/superset/pull/17337#issuecomment-966568187
@dpgaspar @willbarrett @betodealmeida I updated the PR description with the results of our last interactions about security and suggested use cases. I also added examples of the endpoint operations and their configurations. @john-bodley I would really like your review too. @dpgaspar even though the names in the API are editor and viewer, Iām still going to use the owner nomenclature in the database to match our existing schema š You'll notice that the code is not reflecting the current description. I'm looking for more reviews on the security model before implementing it. If you can, just give a thumbs-up in this comment so I know you're ok with it or add a comment otherwise. I'm really excited about my first Python PR so thank you all for the reviews. It's good to be back to full-stack development šš¼ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
