kgabryje opened a new pull request #17503: URL: https://github.com/apache/superset/pull/17503
### SUMMARY When user added a saved metric to Metric control, then removed that metric in dataset, it left the Metric control in a broken state. The reason for that was a faulty logic in a function responsible for synchronising currently added metrics with current state of the dataset. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: see linked issue ### TESTING INSTRUCTIONS 1. Add a saved metric to Metric control and run query 2. Delete that saved metric from dataset 3. Verify that the deleted metric was removed from Metric control and the control is still operable (user is able to add another metric and successfully run query) ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: fixes #14034 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC @junlincc @john-bodley @jinghua-qa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
