villebro commented on a change in pull request #17503:
URL: https://github.com/apache/superset/pull/17503#discussion_r755827137
##########
File path:
superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx
##########
@@ -96,16 +96,17 @@ const getMetricsMatchingCurrentDataset = (
return values;
}
return values.reduce((acc: ValueType[], metric) => {
- if (
- (typeof metric === 'string' || (metric as Metric).metric_name) &&
- (areSavedMetricsEqual ||
+ if (typeof metric === 'string' || (metric as Metric).metric_name) {
Review comment:
Consideration: now that we have those nifty new type guards, would we be
able to introduce those in this PR?
Also, could we add the return type on line 90 (I'm guessing it's now
`ValueType[]`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
