villebro commented on a change in pull request #17501:
URL: https://github.com/apache/superset/pull/17501#discussion_r754199525
##########
File path: superset-frontend/src/views/CRUD/welcome/EmptyState.tsx
##########
@@ -57,11 +57,11 @@ export default function EmptyState({ tableName, tab }:
EmptyStateProps) {
SAVED_QUERIES: 'empty-queries.svg',
};
const mine = (
- <span>{`No ${
- tableName === 'SAVED_QUERIES'
- ? t('saved queries')
- : t(`${tableName.toLowerCase()}`)
- } yet`}</span>
+ <span>
+ {tableName === 'SAVED_QUERIES'
+ ? t('No saved queries yet')
+ : t('No %(tableName)s yet', { tableName: tableName.toLowerCase() })}
Review comment:
Oh right, now I understand that variable (I thought it was a regular
table name in a database and didn't quite understand the point of that sentence
😆). I'll add proper typing and translations for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
