villebro commented on pull request #17501:
URL: https://github.com/apache/superset/pull/17501#issuecomment-975475169


   > I'd suggest you include `*.ts` in babel.cfg and regenerate the pot-File 
with this PR. I'll rebase my PR #17478 on this and add missing translations 
then.
   > 
   > Files/Messages you probably could include in this PR also: 
`/superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx` (Viewed/Modified) 
`/superset-frontend/src/views/CRUD/welcome/DashbaordTable.tsx` and ChartTable 
(View All >>) `/superset-frontend/src/components/Menu/MenueRight.tsx`(SubMenu 
title=Settings)
   
   As this PR is already getting fairly big, I'd like to keep the scope of the 
changes as small as possible. As you were the person that noticed the missing 
`ts` translations, would you be open to opening a PR to fix that bug? If not 
I'm happy to do it, too, but I would love to see the fix attributed to the 
correct person 👍 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to