etr2460 commented on a change in pull request #17410:
URL: https://github.com/apache/superset/pull/17410#discussion_r754546689
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
##########
@@ -320,7 +323,7 @@ const FilterBar: React.FC<FiltersBarProps> = ({
activeKey={editFilterSetId ? TabIds.AllFilters : undefined}
>
<Tabs.TabPane
- tab={t(`All Filters (${filterValues.length})`)}
+ tab={`${t('All filters')} (${numberOfFilters})`}
Review comment:
i know you didn't add this (and instead are just touching it to update
the casing of the string), but this translation string isn't correct. you need
something like:
```
t('All filters (%(numberOfFilters))', numberOfFilters)
```
see here for more details:
https://github.com/apache-superset/superset-ui/tree/master/packages/superset-ui-core/src/translation#api
you'll also want to change the one on line 346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
